launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

+            if not has_mailing_list:
+                reason = 'has a PPA'
+            elif not has_ppa:
+                reason = 'has a mailing list'

This made me blink.

Perhaps:
reasons = []
if has_mailing_list:
    reasons.append('has a mailing list')
if has_ppa:
    reasons.append('has a PPA')
assert reasons, 'rejecting but no reasons found!'
reason = ' and '.join(reasons)

-- 
https://code.launchpad.net/~wallyworld/launchpad/rename-private-team-795771/+merge/72516
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/rename-private-team-795771 into lp:launchpad.