launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

The proposal to merge lp:~abentley/launchpad/bad-state-transition-2 into lp:launchpad has been updated.

Description changed to:

= Summary =
Fix bug #820050: BadStateTransition: Invalid state transition for merge proposal: Superseded -> Approved

== Proposed fix ==
Have the web service treat BadStateTransition as a 400 Bad Request instead of a 500 Internal Server Error.

== Pre-implementation notes ==
None

== Implementation details ==
Modernized nearby tests.

== Tests ==
bin/test -t test_setStatus_invalid_transition test_branchmergeproposal

== Demo and Q/A ==
Create a merge proposal with a target that you can approvve, and resubmit it.
Using the web service, call setStatus(status='Approved) on the proposal.  You should get BadRequest exception, not an Internal Server Error.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/errors.py
  lib/lp/code/model/tests/test_branchmergeproposal.py

For more details, see:
https://code.launchpad.net/~abentley/launchpad/bad-state-transition-2/+merge/72592
-- 
https://code.launchpad.net/~abentley/launchpad/bad-state-transition-2/+merge/72592
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/bad-state-transition-2 into lp:launchpad.