launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/lose-dsp-loc into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/lose-dsp-loc/+merge/72676

DistributionSourcePackage.latest_overall_component is unused (even by the test suite!), so it can die.
-- 
https://code.launchpad.net/~stevenk/launchpad/lose-dsp-loc/+merge/72676
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/lose-dsp-loc into lp:launchpad.

=== modified file 'lib/lp/registry/model/distributionsourcepackage.py'
--- lib/lp/registry/model/distributionsourcepackage.py	2011-08-18 16:40:21 +0000
+++ lib/lp/registry/model/distributionsourcepackage.py	2011-08-24 06:33:34 +0000
@@ -262,14 +262,6 @@
                      "-pocket"])
         return spph
 
-    @property
-    def latest_overall_component(self):
-        """See `IDistributionSourcePackage`."""
-        spph = self.latest_overall_publication
-        if spph:
-            return spph.component
-        return None
-
     def getVersion(self, version):
         """See `IDistributionSourcePackage`."""
         spph = SourcePackagePublishingHistory.select("""