launchpad-reviewers team mailing list archive

[Nigel Babu <nigelbabu@xxxxxxxxx>]

Nigel Babu has proposed merging lp:~nigelbabu/launchpad/811028-time-frame into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #811028 in Launchpad itself: "Time frame 'a moment ago' incorrectly concatenated  to 'on'"
  https://bugs.launchpad.net/launchpad/+bug/811028

For more details, see:
https://code.launchpad.net/~nigelbabu/launchpad/811028-time-frame/+merge/72831

Fix incorrectly adding 'on' by default, use displaydate instead

== Lint ==

bzr: ERROR: unknown command "pipes"
= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/blueprints/templates/specification-index.pt

./bin/lint.sh: line 125: pocketlint: command not found
make: *** [lint] Error 127

-- 
https://code.launchpad.net/~nigelbabu/launchpad/811028-time-frame/+merge/72831
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~nigelbabu/launchpad/811028-time-frame into lp:launchpad.

=== modified file 'lib/lp/blueprints/templates/specification-index.pt'
--- lib/lp/blueprints/templates/specification-index.pt	2011-08-09 14:18:02 +0000
+++ lib/lp/blueprints/templates/specification-index.pt	2011-08-25 06:41:25 +0000
@@ -17,9 +17,10 @@
 
   <tal:registering metal:fill-slot="registering">
     Registered by
-    <tal:registrant tal:replace="structure context/owner/fmt:link" /> on
-    <tal:registrant_date
-      tal:replace="structure context/datecreated/fmt:approximatedate" />
+    <tal:registrant tal:replace="structure context/owner/fmt:link" />
+    <span
+        tal:attributes="title context/datecreated/fmt:datetime"
+        tal:content="context/datecreated/fmt:displaydate" />
   </tal:registering>
 
 <metal:heading fill-slot="heading">