launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~jcsackett/launchpad/404s-confuzzle-me into lp:launchpad

To: mp+73434@xxxxxxxxxxxxxxxxxx
From: "j.c.sackett" <jonathan.sackett@xxxxxxxxxxxxx>
Date: Tue, 30 Aug 2011 20:13:29 -0000
Reply-to: mp+73434@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

j.c.sackett has proposed merging lp:~jcsackett/launchpad/404s-confuzzle-me into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/404s-confuzzle-me/+merge/73434

Summary
=======
Pages that 404 due to privacy concerns confuse our users. While it is our policy to not show private objects or even admit their existence to people without permission, we can add some text to make it clearer that a user might try another login if they expect to see something.

Preimp
=====
None. There are pretty detailed instructions on the bug page.

Implementation
==============
Some text was added to the forbidden and notfound pages, indicating that a user might have the wrong login.

QA
==
Confirm the correct text shows up.
-- 
https://code.launchpad.net/~jcsackett/launchpad/404s-confuzzle-me/+merge/73434
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/404s-confuzzle-me into lp:launchpad.

=== modified file 'lib/lp/app/templates/launchpad-forbidden-macros.pt'
--- lib/lp/app/templates/launchpad-forbidden-macros.pt	2011-05-27 20:26:32 +0000
+++ lib/lp/app/templates/launchpad-forbidden-macros.pt	2011-08-30 20:13:20 +0000
@@ -6,9 +6,14 @@
   <p>
     Sorry, you don't have permission to access this page.
   </p>
-  <p tal:condition="request/lp:person">
+  <div tal:condition="request/lp:person">
+  <p>
     You are logged in as <span tal:content="request/lp:person/title" />.
   </p>
+  <p>
+    You may need to log in under another account to access this url. 
+  </p>
+  </div>
   <p tal:condition="not: request/lp:person">
     You are not logged in.
   </p>

=== modified file 'lib/lp/app/templates/launchpad-notfound.pt'
--- lib/lp/app/templates/launchpad-notfound.pt	2011-05-27 20:26:32 +0000
+++ lib/lp/app/templates/launchpad-notfound.pt	2011-08-30 20:13:20 +0000
@@ -9,14 +9,17 @@
   <body>
     <div class="top-portlet" metal:fill-slot="main">
       <h1>Lost something?</h1>
-      <p>There&#8217;s no page with this address in Launchpad.</p>
+      <p>
+      There&#8217;s no page with this address in Launchpad. If you've been here
+      previously, it may have been removed.
+      </p> 
       <tal:referred condition="view/referrer">
         <p>
           If you got here from a link elsewhere on Launchpad,
           sorry about that.
           We&#8217;ve recorded the problem,
           and we&#8217;ll fix it as soon as we can.
-        </p>
+        </p> 
         <p>
           Otherwise, complain to the maintainers of the page that linked here.
         </p>
@@ -32,7 +35,8 @@
         </p>
       </tal:referred>
       <p tal:condition="not:view/referrer">
-        Check that you entered the address correctly, or search for it:
+      Check that you are logged in as the correct acount, or that you
+      entered the address correctly, or search for it:
       </p>
       <form
         tal:attributes="action string:${rooturl}+search"