launchpad-reviewers team mailing list archive

[Nigel Babu <nigelbabu@xxxxxxxxx>]

Nigel Babu has proposed merging lp:~nigelbabu/launchpad/patch-edit-684548 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~nigelbabu/launchpad/patch-edit-684548/+merge/73514

= Description =
The 'edit' URL for most attachments is hard to find since its only next to the patch link in the right portlet.  This fix will ensure that URL shows up in the bug comment as well.
-- 
https://code.launchpad.net/~nigelbabu/launchpad/patch-edit-684548/+merge/73514
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~nigelbabu/launchpad/patch-edit-684548 into lp:launchpad.

=== modified file 'lib/lp/bugs/templates/bugcomment-box.pt'
--- lib/lp/bugs/templates/bugcomment-box.pt	2011-05-31 14:44:29 +0000
+++ lib/lp/bugs/templates/bugcomment-box.pt	2011-08-31 11:36:26 +0000
@@ -61,6 +61,7 @@
         <a tal:attributes="href python: view.proxiedUrlOfLibraryFileAlias(attachment)"
             tal:content="attachment/title"
             class="sprite download-icon">foo.txt</a>
+        (<a tal:attributes="href attachment/fmt:url">edit</a>)
         (<span
            tal:replace="attachment/libraryfile/content/filesize/fmt:bytes" />,
         <span tal:replace="attachment/libraryfile/mimetype" />)
@@ -71,6 +72,7 @@
       <li tal:repeat="attachment comment/patches" class="download-attachment">
         <a tal:attributes="href python: view.proxiedUrlOfLibraryFileAlias(attachment)"
            tal:content="attachment/title" class="sprite haspatch-icon">foo.txt</a>
+        (<a tal:attributes="href attachment/fmt:url">edit</a>)
         (<span
            tal:replace="attachment/libraryfile/content/filesize/fmt:bytes" />,
         <span tal:replace="attachment/libraryfile/mimetype" />)