launchpad-reviewers team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

Ian Booth has proposed merging lp:~mwhudson/launchpad/ChoiceSource-flexibility into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~mwhudson/launchpad/ChoiceSource-flexibility/+merge/73611

Hi, these small changes make ChoiceSource reusable in a greasemonkey script what I wrote (screenie here: http://people.linaro.org/~mwh/work_item_editor.png).

They should be harmless to other usages in lp.
-- 
https://code.launchpad.net/~mwhudson/launchpad/ChoiceSource-flexibility/+merge/73611
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/ChoiceSource-flexibility into lp:launchpad.

=== modified file 'lib/lp/app/javascript/choiceedit/choiceedit.js'
--- lib/lp/app/javascript/choiceedit/choiceedit.js	2011-08-09 14:18:02 +0000
+++ lib/lp/app/javascript/choiceedit/choiceedit.js	2011-08-31 23:48:25 +0000
@@ -146,6 +146,10 @@
 
     clickable_content: {
       value: true
+    },
+
+    zIndex: {
+      value: 1000
     }
 };
 
@@ -158,9 +162,6 @@
          * @preventable _saveData
          */
         this.publish(SAVE);
-
-        var editicon = this.get('editicon');
-        editicon.original_src = editicon.get("src");
     },
 
     /**
@@ -245,7 +246,8 @@
             title:          this.get("title"),
             items:          this.get("items"),
             value_location: this.get("value_location"),
-            progressbar:    false
+            progressbar:    false,
+            zIndex:         this.get("zIndex")
         });
 
         var that = this;