launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/bug-839395 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #839395 in Launchpad itself: "IndexError in loggerhead add_template_values"
  https://bugs.launchpad.net/launchpad/+bug/839395

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-839395/+merge/73779

= Bug 839395 =

Use latest loggerhead to fix bug 839395: when you browse to a URL for a particular revision and file, if the file was not changed in that revision, it OOPSes.


== Demo and Q/A ==

Go to something like the following (revision 5989 is an existing revision, "ArbitraryName" is an arbitrary file name that is not part of that revision change):

http://bazaar.qastaging.launchpad.net/~bzr-pqm/bzr/bzr.dev/revision/5989/ArbitraryName

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  utilities/sourcedeps.cache
  utilities/sourcedeps.conf
-- 
https://code.launchpad.net/~danilo/launchpad/bug-839395/+merge/73779
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-839395 into lp:launchpad.

=== modified file 'utilities/sourcedeps.cache'
--- utilities/sourcedeps.cache	2011-09-01 10:58:21 +0000
+++ utilities/sourcedeps.cache	2011-09-02 10:39:02 +0000
@@ -1,8 +1,4 @@
 {
-    "bzr-builder": [
-        68, 
-        "launchpad@xxxxxxxxxxxxxxxxx-20101123183213-777lz46xgagn1deg"
-    ], 
     "testresources": [
         16, 
         "robertc@xxxxxxxxxxxxxxxxx-20050911111209-ee5da49011cf936a"
@@ -31,14 +27,18 @@
         24, 
         "launchpad@xxxxxxxxxxxxxxxxx-20100601182722-wo7h2fh0fvyw3aaq"
     ], 
-    "lpreview": [
-        23, 
-        "launchpad@xxxxxxxxxxxxxxxxx-20090720061538-euyh68ifavhy0pi8"
-    ], 
     "bzr-git": [
         259, 
         "launchpad@xxxxxxxxxxxxxxxxx-20110601140035-gl5merbechngjw5s"
     ], 
+    "loggerhead": [
+        456, 
+        "danilo@xxxxxxxxxxxxx-20110902102252-phc11upmjw8tz1mg"
+    ], 
+    "bzr-builder": [
+        68, 
+        "launchpad@xxxxxxxxxxxxxxxxx-20101123183213-777lz46xgagn1deg"
+    ], 
     "bzr-loom": [
         50, 
         "launchpad@xxxxxxxxxxxxxxxxx-20110722102404-hl1z8uzhhwiol34l"
@@ -47,9 +47,9 @@
         4, 
         "sinzui-20090526164636-1swugzupwvjgomo4"
     ], 
-    "loggerhead": [
-        455, 
-        "danilo@xxxxxxxxxxxxx-20110817125309-2r1fgcrqt5kr5h43"
+    "lpreview": [
+        23, 
+        "launchpad@xxxxxxxxxxxxxxxxx-20090720061538-euyh68ifavhy0pi8"
     ], 
     "difftacular": [
         6, 

=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf	2011-09-01 10:58:21 +0000
+++ utilities/sourcedeps.conf	2011-09-02 10:39:02 +0000
@@ -6,7 +6,7 @@
 cscvs lp:~launchpad-pqm/launchpad-cscvs/devel;revno=432
 dulwich lp:~launchpad-pqm/dulwich/devel;revno=426
 difftacular lp:difftacular;revno=6
-loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=455
+loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=456
 lpreview lp:~launchpad-pqm/bzr-lpreview/devel;revno=23
 mailman lp:~launchpad-pqm/mailman/2.1;revno=976
 old_xmlplus lp:~launchpad-pqm/dtdparser/trunk;revno=4