launchpad-reviewers team mailing list archive

[Nigel Jones <dev@xxxxxxxxxx>]

The proposal to merge lp:~dev-nigelj/launchpad/bug-697157 into lp:launchpad has been updated.

Description changed to:

Summary

If you assign yourself to a bug, under certain circumstances an e-mail will be sent saying "Nigel Jones (dev-nigelj) has assigned this bug to you for Launchpad itself:" when a better/more logical message would be "You have assigned this bug to yourself for Launchpad itself:"

Proposed Fix/Implementation Details

The Proposed and Implemented fix is to include an if statement, to verify if that the event creator is the same as the bug task assignee and generate the new message, otherwise to use the existing

Tests

All tests related to this change pass, and I couldn't see any new failures on a full test natty run.

The change also introduces a new test in lib/lp/bugs/mail/tests/test_bug_task_assignment.py (test_self_assignee_notification_message()) which tests for this new message in the situations that it should be generated.

Demo/QA

w/ AppServer mail setup in a way that you can read all e-mails sent
Create a new bug for "Ubuntu" under one username
Logout & login as a second username (not one that is a member of Ubuntu Team)
Assign the bug to yourself, verify the correct statement regarding bug assignment is used in the [NEW] e-mail.

Lint

make lint is now clean after r13865 in this branch

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/mail/newbug.py
  lib/lp/bugs/mail/tests/test_bug_task_assignment.py


For more details, see:
https://code.launchpad.net/~dev-nigelj/launchpad/bug-697157/+merge/74035
-- 
https://code.launchpad.net/~dev-nigelj/launchpad/bug-697157/+merge/74035
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~dev-nigelj/launchpad/bug-697157 into lp:launchpad.