← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~rvb/launchpad/sync-bug-827608-spph-creator into lp:launchpad/db-devel

 

The proposal to merge lp:~rvb/launchpad/sync-bug-827608-spph-creator into lp:launchpad/db-devel has been updated.

Description changed to:

This branch involves schema changes so it targets db-devel.

This branch is a first step towards fixing 827608: it adds the creator column to SourcePackagePublishingHistory (spph). We are not trying to fix existing spph rows (we could /approximate/ spph.creator by using the spr's creator) because the spph table has ~1.6M rows and also because the approximation would not be good enough. This means that the code that will use the new column will have to deal with Null values.

= Tests =

./bin/test -vvc test_copypackage test_copy_sets_creator

= Q/A =

None

For more details, see:
https://code.launchpad.net/~rvb/launchpad/sync-bug-827608-spph-creator/+merge/74571
-- 
https://code.launchpad.net/~rvb/launchpad/sync-bug-827608-spph-creator/+merge/74571
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/sync-bug-827608-spph-creator into lp:launchpad/db-devel.


References