launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #796140 in Launchpad itself: "Disk utilization stats gatherer not ignoring temporary tables"
  https://bugs.launchpad.net/launchpad/+bug/796140
  Bug #844616 in Launchpad itself: "full-update.py too picky about long running transactions"
  https://bugs.launchpad.net/launchpad/+bug/844616

For more details, see:
https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/74607

= Summary =

full-update.py is too sensitive to long running transactions.

== Proposed fix ==

Increase the threshold of what is considered 'long running' from 10 seconds to 60 seconds.

== Pre-implementation notes ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/schema/preflight.py

./database/schema/preflight.py
       7: '_pythonpath' imported but unused
-- 
https://code.launchpad.net/~stub/launchpad/pending-db-changes/+merge/74607
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/pending-db-changes into lp:launchpad/db-devel.

=== modified file 'database/schema/preflight.py'
--- database/schema/preflight.py	2011-08-11 11:26:13 +0000
+++ database/schema/preflight.py	2011-09-08 14:18:27 +0000
@@ -164,7 +164,7 @@
                 % ', '.join(FRAGILE_USERS))
         return success
 
-    def check_long_running_transactions(self, max_secs=10):
+    def check_long_running_transactions(self, max_secs=60):
         """Return False if any nodes have long running transactions open.
 
         max_secs defines what is long running. For database rollouts,