launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/bug-847696 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #847696 in Launchpad itself: "Gina should commit after dominating"
  https://bugs.launchpad.net/launchpad/+bug/847696

For more details, see:
https://code.launchpad.net/~jtv/launchpad/bug-847696/+merge/74984

Q/A for the Dominator overhaul and provisional Gina domination revealed a forgotten commit.  It was in a previous incarnation of one of the many branches that make up this change, but I forgot to port it over to a rewrite.  This branch adds the commit back.
-- 
https://code.launchpad.net/~jtv/launchpad/bug-847696/+merge/74984
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/bug-847696 into lp:launchpad.

=== modified file 'scripts/gina.py'
--- scripts/gina.py	2011-09-08 08:00:10 +0000
+++ scripts/gina.py	2011-09-12 12:37:36 +0000
@@ -156,6 +156,7 @@
     # XXX JeroenVermeulen 2011-09-07 bug=843728: Dominate binaries as well.
     dominate_imported_source_packages(
         log, distro, distroseries, pocket, packages_map)
+    ztm.commit()
 
     if source_only:
         log.info('Source only mode... done')