launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/denorm-bspph-model into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-model/+merge/75100

Sprinkle in the model changes for {B,S}PPH denormalisation. This is able to land right away, due to the db patch having landed.
-- 
https://code.launchpad.net/~stevenk/launchpad/denorm-bspph-model/+merge/75100
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/denorm-bspph-model into lp:launchpad.

=== modified file 'lib/lp/soyuz/interfaces/publishing.py'
--- lib/lp/soyuz/interfaces/publishing.py	2011-09-11 11:08:30 +0000
+++ lib/lp/soyuz/interfaces/publishing.py	2011-09-13 01:10:36 +0000
@@ -326,6 +326,12 @@
     id = Int(
             title=_('ID'), required=True, readonly=True,
             )
+    sourcepackagenameID = Attribute(
+        "The DB id for the sourcepackagename.")
+    sourcepackagename = Int(
+        title=_('The source package name being published'),
+        required=False, readonly=False,
+        )
     sourcepackagereleaseID = Attribute(
         "The DB id for the sourcepackagerelease.")
     sourcepackagerelease = Int(
@@ -672,6 +678,12 @@
     id = Int(
             title=_('ID'), required=True, readonly=True,
             )
+    binarypackagenameID = Attribute(
+        "The DB id for the binarypackagename.")
+    binarypackagename = Int(
+        title=_('The binary package name being published'),
+        required=False, readonly=False,
+        )
     binarypackagerelease = Int(
             title=_('The binary package being published'), required=False,
             readonly=False,

=== modified file 'lib/lp/soyuz/model/publishing.py'
--- lib/lp/soyuz/model/publishing.py	2011-09-11 11:08:30 +0000
+++ lib/lp/soyuz/model/publishing.py	2011-09-13 01:10:36 +0000
@@ -421,6 +421,8 @@
     """A source package release publishing record."""
     implements(ISourcePackagePublishingHistory)
 
+    sourcepackagename = ForeignKey(foreignKey='SourcePackageName',
+        dbName='sourcepackagename')
     sourcepackagerelease = ForeignKey(foreignKey='SourcePackageRelease',
         dbName='sourcepackagerelease')
     distroseries = ForeignKey(foreignKey='DistroSeries',
@@ -904,6 +906,8 @@
 
     implements(IBinaryPackagePublishingHistory)
 
+    binarypackagename = ForeignKey(foreignKey='BinaryPackageName',
+        dbName='binarypackagename')
     binarypackagerelease = ForeignKey(foreignKey='BinaryPackageRelease',
                                       dbName='binarypackagerelease')
     distroarchseries = ForeignKey(foreignKey='DistroArchSeries',