launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/missing-all-still into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/missing-all-still/+merge/75286

There were 1 imports of names not appearing in the __all__.
You should not import GeneralizedPublication from lp.archivepublisher.domination:
    lp.soyuz.scripts.gina.dominate

-- 
https://code.launchpad.net/~stevenk/launchpad/missing-all-still/+merge/75286
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/missing-all-still into lp:launchpad.

=== modified file 'lib/lp/archivepublisher/domination.py'
--- lib/lp/archivepublisher/domination.py	2011-09-09 14:30:03 +0000
+++ lib/lp/archivepublisher/domination.py	2011-09-14 01:07:19 +0000
@@ -50,7 +50,10 @@
 
 __metaclass__ = type
 
-__all__ = ['Dominator']
+__all__ = [
+    'Dominator',
+    'GeneralizedPublication',
+    ]
 
 from datetime import timedelta