launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

The proposal to merge lp:~stevenk/launchpad/private-bug-unsubscribe-confirm into lp:launchpad has been updated.

Description changed to:

This is my first JS branch, so please be gentle.

This bug now brings up a confirmation overlay when a user using the +subscriptions page on a private bug removes their subscription. I have added tests as well as checking that the confirmationoverlay is not present for a public bug.

This branch does not fully fix the bug, however, so I've added an XXX to the other place that needs fixing, and I will address it in a future branch.

I've also drive-by changed a comment and docstring that looked like it rambled.

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/private-bug-unsubscribe-confirm/+merge/76326
-- 
https://code.launchpad.net/~stevenk/launchpad/private-bug-unsubscribe-confirm/+merge/76326
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/private-bug-unsubscribe-confirm into lp:launchpad.