← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~mbp/launchpad/855150-mail-disabled into lp:launchpad

 

The proposal to merge lp:~mbp/launchpad/855150-mail-disabled into lp:launchpad has been updated.

Description changed to:

This handles bug 858605 (split from bug 855150), which is that Launchpad sends mail to people who have deactivated accounts.  I addressed this by changing get_recipients to check against the account table too, and adding a unit test for this.  I also checked the uses of get_recipients and none seems like it would actually want to be mailing deactivated accounts - perhaps the only case for that would be if people wanted to reactivate them, and I think they have to log in first.

For more details, see:
https://code.launchpad.net/~mbp/launchpad/855150-mail-disabled/+merge/76876
-- 
https://code.launchpad.net/~mbp/launchpad/855150-mail-disabled/+merge/76876
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/855150-mail-disabled into lp:launchpad.


References