launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~wallyworld/launchpad/bug-subscribers-portlet-json into lp:launchpad

To: William Grant <me@xxxxxxxxxxxxxxxxxx>
From: Ian Booth <ian.booth@xxxxxxxxxxxxx>
Date: Mon, 26 Sep 2011 08:50:14 -0000
In-reply-to: <20110926043619.2493.6857.codereview@wampee.canonical.com>
Reply-to: mp+76920@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> What's done with the resulting JSON? Is there a reason you can't just put the
> dict in the IJSONRequestCache and let that handle it?

The resulting json is used to populate the subscriers portlet and then discarded. It doesn't belong in the cache. It's the same json that is sent to the page on loading when the portlet is first populated.
-- 
https://code.launchpad.net/~wallyworld/launchpad/bug-subscribers-portlet-json/+merge/76920
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/bug-subscribers-portlet-json into lp:launchpad.

References

Re: [Merge] lp:~wallyworld/launchpad/bug-subscribers-portlet-json into lp:launchpad
From: William Grant, 2011-09-26