launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

Martin Pool has proposed merging lp:~mbp/launchpad/get-the-code into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~mbp/launchpad/get-the-code/+merge/77496

It's great that Launchpad's code is open and can be changed by anyone.

If someone is interested in contributing, they probably want to start by reading dev.launchpad.net not just jumping into the loggerhead view of Launchpad, which isn't so useful without reading the instructions.

I think this deserves a majuscule and exclamation mark.
-- 
https://code.launchpad.net/~mbp/launchpad/get-the-code/+merge/77496
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/get-the-code into lp:launchpad.

=== modified file 'lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt'
--- lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt	2010-10-26 01:26:00 +0000
+++ lib/canonical/launchpad/pagetests/basics/demo-and-lpnet.txt	2011-09-29 10:34:03 +0000
@@ -51,7 +51,7 @@
     <style...url(/@@/demo)...</style>
     ...
     >>> print extract_text(find_tag_by_id(browser.contents, 'lp-version'))
-    &bull; r... devmode demo site (get the code)
+    &bull; r... devmode demo site (Get the code!)
 
     >>> print extract_text(find_tags_by_class(
     ...     browser.contents, 'sitemessage')[0])
@@ -70,6 +70,6 @@
 
     >>> browser.open('http://launchpad.dev/ubuntu')
     >>> print extract_text(find_tag_by_id(browser.contents, 'lp-version'))
-    &bull; r... devmode (get the code)
+    &bull; r... devmode (Get the code!)
     >>> len(find_tags_by_class(browser.contents, 'sitemessage'))
     0

=== modified file 'lib/lp/app/browser/tests/base-layout.txt'
--- lib/lp/app/browser/tests/base-layout.txt	2011-08-30 23:30:01 +0000
+++ lib/lp/app/browser/tests/base-layout.txt	2011-09-29 10:34:03 +0000
@@ -174,7 +174,7 @@
     Terms of use http://launchpad.dev/legal
     Contact Launchpad Support /feedback
     System status http://identi.ca/launchpadstatus
-    get the code https://code.launchpad.net/~launchpad-pqm/launchpad/stable/
+    Get the code! https://dev.launchpad.net/
 
 
 Page registering

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2011-09-27 17:27:43 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2011-09-29 10:34:03 +0000
@@ -269,8 +269,8 @@
         r<tal:revno replace="revno" />
         <tal:devmode condition="devmode">devmode</tal:devmode>
         <tal:demo condition="is_demo">demo site</tal:demo>
-        (<a href="https://code.launchpad.net/~launchpad-pqm/launchpad/stable/";
-             >get the code</a>)
+        (<a href="https://dev.launchpad.net/";
+             >Get the code!</a>)
       </span>
     </div>
   </div>