launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

The proposal to merge lp:~danilo/launchpad/bug-869089 into lp:launchpad has been updated.

Description changed to:

= Bug 869089 =

I was under the wrong impression that global suggestions have stopped working. However, the logic for updating the cached SuggestivePOTemplate table was using official_rosetta field instead.

So, I've decided to fix this (basically rosetta task of bug 627631, which has been marked 'fix released' for all of Launchpad, probably the migration to one single project losing the distinction), and the translations part of bug 677532 (because I had to :).

== Proposed fix ==

Use translations_usage directly everywhere instead of using official_rosetta.  Good riddance to official_rosetta.

== Implementation details ==

One problem I hit was that the tests sampledata was not updated with the migration from official_rosetta to translations_usage, so I did that (that's why only current.sql is updated).

== Tests ==

bin/test -vvm lp.translations (though, I ran full test suite already and fixed problems that caused failing tests)

== Demo and Q/A ==

Make sure TranslationAdmins (eg. all of Launchpad team) can access translations.l.n/(project|distro)/+settings pages and change the "uses translations" setting.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  database/sampledata/current.sql
  lib/lp/registry/model/projectgroup.py
  lib/lp/registry/doc/distribution.txt
  lib/lp/translations/scripts/tests/test_cache_suggestive_templates.py
  lib/lp/translations/tests/test_pofile.py
  lib/lp/registry/configure.zcml
  lib/lp/translations/browser/distribution.py
  lib/lp/app/interfaces/launchpad.py
  lib/lp/translations/browser/tests/test_productserieslanguage_views.py
  lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt
  lib/lp/translations/browser/tests/test_baseexportview.py
  lib/lp/translations/browser/tests/test_distroserieslanguage_views.py
  lib/lp/translations/tests/test_shared_potemplate.py
  lib/lp/translations/browser/tests/test_translationimportqueueentry.py
  lib/lp/translations/browser/tests/test_translationlinksaggregator.py
  lib/lp/registry/interfaces/projectgroup.py
  lib/lp/translations/scripts/translations_to_branch.py
  lib/lp/registry/model/product.py
  lib/lp/registry/tests/test_service_usage.py
  lib/lp/registry/browser/tests/distribution-views.txt
  lib/canonical/launchpad/database/launchpadstatistic.py
  lib/lp/translations/model/translationsperson.py
  lib/lp/translations/interfaces/hastranslationtemplates.py
  lib/lp/translations/doc/potmsgset.txt
  lib/lp/registry/browser/distribution.py
  lib/lp/translations/model/potemplate.py
  lib/lp/registry/model/distribution.py
  lib/lp/translations/browser/tests/test_product_view.py
  lib/lp/translations/browser/potemplate.py


For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-869089/+merge/78819
-- 
https://code.launchpad.net/~danilo/launchpad/bug-869089/+merge/78819
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-869089 into lp:launchpad.