launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/rest-glob-imports into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #672600 in Launchpad itself: "canonical.launchpad.rest.__init__ re-exports glob interfaces"
  https://bugs.launchpad.net/launchpad/+bug/672600

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/rest-glob-imports/+merge/78902

Glob imports are bad.
-- 
https://code.launchpad.net/~stevenk/launchpad/rest-glob-imports/+merge/78902
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/rest-glob-imports into lp:launchpad.

=== modified file 'lib/canonical/launchpad/rest/__init__.py'
--- lib/canonical/launchpad/rest/__init__.py	2010-11-08 16:08:22 +0000
+++ lib/canonical/launchpad/rest/__init__.py	2011-10-11 01:08:24 +0000
@@ -1,16 +0,0 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-
-# pylint: disable-msg=W0401
-
-"""Code for Launchpad's RESTful web services."""
-
-# XXX: JonathanLange 2010-11-08 bug=672600: Should not re-export from
-# here. Instead, import sites should import directly from modules.
-
-from canonical.launchpad.rest.bytestorage import *
-from canonical.launchpad.rest.me import *
-from canonical.launchpad.rest.pillarset import *
-from lp.bugs.adapters.bug import *
-
-

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2011-10-05 15:13:36 +0000
+++ lib/lp/registry/configure.zcml	2011-10-11 01:08:24 +0000
@@ -982,8 +982,8 @@
                 interface="lp.registry.interfaces.person.IPersonSet"/>
         </securedutility>
         <securedutility
-            class="canonical.launchpad.rest.MeLink"
-            provides="canonical.launchpad.rest.IMeLink">
+            class="canonical.launchpad.rest.me.MeLink"
+            provides="canonical.launchpad.rest.me.IMeLink">
             <allow
                 interface="lazr.restful.interfaces.ITopLevelEntryLink"/>
             <allow