launchpad-reviewers team mailing list archive

[Michael Hudson-Doyle <michael.hudson+lp@xxxxxxxxxx>]

Michael Hudson-Doyle has proposed merging lp:~mwhudson/launchpad/i-dont-believe-for-a-minute-that-steveIsFixingThis into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~mwhudson/launchpad/i-dont-believe-for-a-minute-that-steveIsFixingThis/+merge/79047

Steve is not fixing this.
-- 
https://code.launchpad.net/~mwhudson/launchpad/i-dont-believe-for-a-minute-that-steveIsFixingThis/+merge/79047
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mwhudson/launchpad/i-dont-believe-for-a-minute-that-steveIsFixingThis into lp:launchpad.

=== modified file 'lib/canonical/launchpad/webapp/authorization.py'
--- lib/canonical/launchpad/webapp/authorization.py	2011-04-27 16:01:06 +0000
+++ lib/canonical/launchpad/webapp/authorization.py	2011-10-12 01:11:28 +0000
@@ -41,9 +41,6 @@
 from lp.app.interfaces.security import IAuthorization
 
 
-steveIsFixingThis = False
-
-
 LAUNCHPAD_SECURITY_POLICY_CACHE_KEY = 'launchpad.security_policy_cache'
 
 
@@ -190,12 +187,7 @@
         # This check shouldn't be needed, strictly speaking.
         # However, it is here as a "belt and braces".
 
-        # XXX Steve Alexander 2005-01-12:
-        # This warning should apply to the policy in zope3 also.
         if permission == 'zope.Public':
-            if steveIsFixingThis:
-                warnings.warn(
-                    'zope.Public being used raw on object %r' % object)
             return True
         if permission is CheckerPublic:
             return True