launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Review: Disapprove

Rather than fix this in every system, we should just fix it once in Storm. Storm catches the PostgreSQL exceptions, puts its stores in a state so they will attempt to reconnect, and raises DisconnectionError. In particular, I don't think the proposed patch works as the Storm store is being left in an inconsistent state (the next request will likely fail, and the subsequent one might reconnect).

I think this might also be the issue Garry saw with making the appserver return 503 errors when the database was unavailable.
-- 
https://code.launchpad.net/~allenap/launchpad/oneiric-librarian-bug-871596/+merge/79175
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/oneiric-librarian-bug-871596 into lp:launchpad.