launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/launchpad/contactuser-typo into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/launchpad/contactuser-typo/+merge/79208

= Summary =

I'm getting this bit of bad English on the +contactuser page:

«You have reach your quota for direct contact of other Launchpad users. You can try again in 20 minutes»


== Proposed fix ==

Replace “reach” with “reached” and “direct contact of” with “directly contacting”; conclude the latter sentence with a full stop.


== Tests ==

Not sure; running 'em all.


== Demo and Q/A ==

The page should still render normally, and when quota are exceeded.  Make sure there's no spurious whitespace before the full stop.


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/contact-user.pt
-- 
https://code.launchpad.net/~jtv/launchpad/contactuser-typo/+merge/79208
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/launchpad/contactuser-typo into lp:launchpad.

=== modified file 'lib/lp/registry/templates/contact-user.pt'
--- lib/lp/registry/templates/contact-user.pt	2009-08-31 18:23:45 +0000
+++ lib/lp/registry/templates/contact-user.pt	2011-10-13 05:44:50 +0000
@@ -24,10 +24,10 @@
         </div>
       </tal:allowed>
       <tal:disallowed tal:condition="not:view/contact_is_allowed">
-        <p>You have reach your quota for direct contact of other Launchpad
+        <p>You have reached your quota for directly contacting other Launchpad
            users.  You can try again
           <tal:next_try
-            tal:content="view/next_try/fmt:displaydate">X</tal:next_try>
+            tal:content="view/next_try/fmt:displaydate">X</tal:next_try>.
         </p>
       </tal:disallowed>
       <tal:disallowed tal:condition="not:view/has_valid_email_address">