launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/germinate-armhf into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #874298 in Launchpad itself: "cron.germinate needs to be fixed to examine the armhf architecture"
  https://bugs.launchpad.net/launchpad/+bug/874298

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/germinate-armhf/+merge/79416

= Summary =

Bug 874298: cron.germinate has a hardcoded list of architectures which does not include the new armhf architecture in precise.  Either armhf should be added, or (preferably) cron.germinate should be fixed to detect the list of architectures automatically.

== Proposed fix ==

lp-query-distro.py is available for shell scripts to use to determine various things about distributions; indeed, cron.germinate already uses it to get the default suite.  It can also print the list of architectures in a suite.  Rather than hardcoding the list of architectures and having to land branches to change it every so often, we should just autodetect it.

== Pre-implementation notes ==

<bigjools> cjwatson: +1

== Tests ==

As far as I know this chunk of code is currently untested.  (Also, I've been given to understand in the past that LP considers it to be owned by Ubuntu Engineering.)

== Demo and Q/A ==

Run cron.germinate on dogfood for Ubuntu precise and then run 'ls -l /srv/launchpad.net/ubuntu-archive/ubuntu-germinate/required_ubuntu_precise*'; output for armhf should exist, and also output for other architectures should exist and have current timestamps (to confirm that we haven't lost amd64/armel/i386/powerpc).
-- 
https://code.launchpad.net/~cjwatson/launchpad/germinate-armhf/+merge/79416
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/germinate-armhf into lp:launchpad.

=== modified file 'cronscripts/publishing/cron.germinate'
--- cronscripts/publishing/cron.germinate	2011-07-19 15:08:45 +0000
+++ cronscripts/publishing/cron.germinate	2011-10-14 15:43:23 +0000
@@ -29,6 +29,7 @@
 trap cleanup EXIT
 
 suite=`$LAUNCHPADROOT/scripts/ftpmaster-tools/lp-query-distro.py development`
+archs=`$LAUNCHPADROOT/scripts/ftpmaster-tools/lp-query-distro.py -s "$suite" archs`
 
 echo -n "Running germinate... "
 cd $GERMINATEROOT
@@ -44,7 +45,7 @@
   base="dists/$suite/$component"
   mkdir -p "$base/source"
   zcat "$ARCHIVEROOT/$base/source/Sources.gz" > "$base/source/Sources"
-  for arch in i386 amd64 powerpc armel; do
+  for arch in $archs; do
     mkdir -p "$base/binary-$arch" "$base/debian-installer/binary-$arch"
     zcat "$ARCHIVEROOT/$base/binary-$arch/Packages.gz" \
       > "$base/binary-$arch/Packages"
@@ -59,7 +60,7 @@
 for distro in ubuntu kubuntu kubuntu-mobile edubuntu xubuntu mythbuntu lubuntu ubuntustudio; do
   DISTRO="$(echo $distro | tr a-z A-Z)"
   germinate_suite="$distro.$suite"
-  for arch in i386 amd64 powerpc armel; do
+  for arch in $archs; do
     # Run germinate
     echo " **************** $distro/$suite/$arch ********************* " >> germinate.output
     germinate --no-rdepends -m "file://$(pwd)/" -s "$germinate_suite" -d "$suite" -c "$germinate_components" -a $arch >> germinate.output 2>&1