launchpad-reviewers team mailing list archive

[Данило Шеган <danilo@xxxxxxxxxxxxx>]

Данило Шеган has proposed merging lp:~danilo/launchpad/bug-877179 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #877179 in Launchpad itself: "Drop rosetta@xxxxxxxxxxxxx email address"
  https://bugs.launchpad.net/launchpad/+bug/877179

For more details, see:
https://code.launchpad.net/~danilo/launchpad/bug-877179/+merge/79781

= Bug 877179: remove use of rosetta@xxxxxxxxxxxxx =

This branch removes all use of rosetta@xxxxxxxxxxxxx alias (mostly in "from" for emails, but some of them were "to" as well).  "From" instances are mostly replaced with noreply@xxxxxxxxxxxxx, and "To" with launchpad-error-reports@ list.

rosetta@xxxxxxxxxxxxx is still set as the contact address for rosetta-experts team in the sampledata.  Not sure if it's worth changing that, since that address is as good as any other.

== Tests ==

bin/test -vvm lp.translations

== Demo and Q/A ==

Test-suite and checking translation imports and exports email come from noreply@xxxxxxxxxxxxx.

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/config/schema-lazr.conf
  lib/lp/translations/doc/pofile-verify-stats.txt
  lib/lp/translations/scripts/verify_pofile_stats.py
  lib/lp/translations/scripts/po_export_queue.py
  lib/lp/translations/scripts/po_import.py

./lib/canonical/config/schema-lazr.conf
     592: Line exceeds 78 characters.
    1216: Line exceeds 78 characters.
    1223: Line exceeds 78 characters.
-- 
https://code.launchpad.net/~danilo/launchpad/bug-877179/+merge/79781
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~danilo/launchpad/bug-877179 into lp:launchpad.