launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

Raphaël Badin has proposed merging lp:~rvb/launchpad/bug-878781 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #878781 in Launchpad itself: "UnicodeEncodeError is raised by makeDailyBuilds when an error contains non ascii chars."
  https://bugs.launchpad.net/launchpad/+bug/878781

For more details, see:
https://code.launchpad.net/~rvb/launchpad/bug-878781/+merge/79951

This branch simply uses repr(error_message) instead of str(error_message) to avoid the dreaded UnicodeDecodeError raised when error_message contains non ascii chars.
-- 
https://code.launchpad.net/~rvb/launchpad/bug-878781/+merge/79951
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/bug-878781 into lp:launchpad.

=== modified file 'lib/lp/code/model/sourcepackagerecipebuild.py'
--- lib/lp/code/model/sourcepackagerecipebuild.py	2011-10-18 11:14:21 +0000
+++ lib/lp/code/model/sourcepackagerecipebuild.py	2011-10-20 11:37:52 +0000
@@ -227,7 +227,7 @@
                     # disabled, security, wrong pocket etc
                     logger.debug(
                         ' - daily build failed for %s: %s',
-                        series_name, str(e))
+                        series_name, repr(e))
                 except BuildNotAllowedForDistro:
                     logger.debug(
                         ' - cannot build against %s.' % series_name)