launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

Martin Pool has proposed merging lp:~mbp/launchpad/jobs-link into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~mbp/launchpad/jobs-link/+merge/80307

This adds a link to the Canonical Careers site from the global footer.  There is a feature flag so we can turn it off later if we want.

Obviously adding more links has a cost, but getting developer candidates has value, and there aren't that many links there at the moment.

http://people.canonical.com/~mbp/launchpad-screenshots/2011-10-25_20:22:43.png
-- 
https://code.launchpad.net/~mbp/launchpad/jobs-link/+merge/80307
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/jobs-link into lp:launchpad.

=== modified file 'lib/lp/app/browser/tests/base-layout.txt'
--- lib/lp/app/browser/tests/base-layout.txt	2011-09-30 00:31:12 +0000
+++ lib/lp/app/browser/tests/base-layout.txt	2011-10-25 09:27:25 +0000
@@ -174,6 +174,7 @@
     Terms of use http://launchpad.dev/legal
     Contact Launchpad Support /feedback
     Blog http://blog.launchpad.net/
+    Jobs http://www.canonical.com/about-canonical/careers
     System status http://identi.ca/launchpadstatus
     Get the code! https://dev.launchpad.net/
 

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2011-10-06 14:04:37 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2011-10-25 09:27:25 +0000
@@ -266,6 +266,11 @@
        • 
       <a href="http://blog.launchpad.net/";
 	>Blog</a>
+      <tal:jobslink condition="not: features/baselayout.jobs_link.disabled">
+	&nbsp;&bull;&nbsp;
+	<a href="http://www.canonical.com/about-canonical/careers";
+		>Jobs</a>
+      </tal:jobslink>
       &nbsp;&bull;&nbsp;
       <a href="http://identi.ca/launchpadstatus";
         >System status</a>

=== modified file 'lib/lp/services/features/flags.py'
--- lib/lp/services/features/flags.py	2011-10-23 23:22:41 +0000
+++ lib/lp/services/features/flags.py	2011-10-25 09:27:25 +0000
@@ -40,6 +40,10 @@
 # NOTE: "default behaviour" does not specify a default value.  It
 # merely documents the code's behaviour if no value is specified.
 flag_info = sorted([
+    ('baselayout.jobs_link.disabled',
+     'boolean',
+     'Hide the link to the Canonical Careers site.',
+     ''),
     ('bugs.bugtracker_components.enabled',
      'boolean',
      ('Enables the display of bugtracker components.'),