launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

This looks wrong:
38	+ if total_affected == 1:
39	+ return "This bug affects you and 1 other person"

surely thats 'This bug affects you', and a count of 2 is you and 1 other person, and 3+ is you and %d other people.

I think the approach is reasonable but you should consider feature flagging it in case it is slower. Also changing templates etc would just messy up the clarity of this change.
-- 
https://code.launchpad.net/~mbp/launchpad/678090-affected-count/+merge/81108
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/678090-affected-count into lp:launchpad.