launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

The proposal to merge lp:~deryck/launchpad/orderby-bar-settings-slot into lp:launchpad has been updated.

Description changed to:

This branch updates OrderByBar to allow for the addition of a config slot, a div added to the object which other widgets can use to connect themselves to OrderByBar widgets.

When config_slot is true, a rendered OrderByBar will have an empty div at the far right of the bar, with a light gray vertical separator bar.  This will look similar to the prototype found at http://people.canonical.com/~deryck/new-buglistings/new-buglistings.html except that the settings icon will not be present, just the div to hold that icon.  The settings icon will be handled by a new widget I'm working on, and that widget will accept the node created here as it's srcNode and place the wired up settings icon into the OrderByBar via this node.

For more details, see:
https://code.launchpad.net/~deryck/launchpad/orderby-bar-settings-slot/+merge/81148
-- 
https://code.launchpad.net/~deryck/launchpad/orderby-bar-settings-slot/+merge/81148
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/orderby-bar-settings-slot into lp:launchpad.