launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

Gavin Panella has proposed merging lp:~allenap/launchpad/bug-export-schema into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~allenap/launchpad/bug-export-schema/+merge/81699

Improve the bug export schema in light of https://answers.launchpad.net/launchpad/+question/177795.
-- 
https://code.launchpad.net/~allenap/launchpad/bug-export-schema/+merge/81699
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/launchpad/bug-export-schema into lp:launchpad.

=== modified file 'doc/bug-export.rnc'
--- doc/bug-export.rnc	2007-09-13 13:11:31 +0000
+++ doc/bug-export.rnc	2011-11-09 10:25:06 +0000
@@ -7,6 +7,7 @@
 boolean = "True" | "False"
 lpname = xsd:string { pattern = "[a-z0-9][a-z0-9\+\.\-]*" }
 cvename = xsd:string { pattern = "(19|20)[0-9][0-9]-[0-9][0-9][0-9][0-9]" }
+text1 = xsd:string { minLength = "1" }
 
 # XXX: jamesh 2006-04-11 bug=105401:
 # These status and importance values need to be kept in sync with the
@@ -35,10 +36,15 @@
 # Content model for a person element.  The element content is the
 # person's name.  For successful bug import, an email address must be
 # provided.
-person = (
+person_nobody = (
+  attribute name { string "nobody" })
+person_normal = (
   attribute name { lpname }?,
-  attribute email { text }?,
+  attribute email { text1 },
   text)
+person = (
+  person_nobody |
+  person_normal)
 
 lpbugs = element launchpad-bugs { bug* }
 
@@ -89,9 +95,9 @@
 attachment = element attachment {
   attribute href { xsd:anyURI }? &
   element type { "PATCH" | "UNSPECIFIED" }? &
-  element filename { text }? &
+  element filename { text1 }? &
   # The following will likely be renamed summary in a future version.
   element title { text }? &
   element mimetype { text }? &
-  element contents { xsd:base64Binary }
+  element contents { xsd:base64Binary { minLength = "1" } }
 }