launchpad-reviewers team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

The proposal to merge lp:~adeuring/launchpad/banner-for-beta-features-2 into lp:launchpad has been updated.

Description changed to:

This branch adds a banner pages having features in beta status.

The core idea: LP.cache has an entry "beta_features", which
contains copies of the tuples from lp.services.features.flags.flag_info
for features matching these conditions:

- the feature name appears in view.beta_features
- when a page is rendered, the value of the feature flag is not the
  default value. (see
  lp:~adeuring/launchpad/banner-for-beta-features for details)

The function beta_notification() in beta-notification.js checks if
LP.cache.beta_features is not emtpy, and if so, it adds a banner to
the page showing the title of the beta feature flags and optionally
a link to a page with more information about the feature.

The banner can be hidden by a click on the "hide" link.

The new property BugTaskSearchListingView.beta_features (which
overrides LaunchpadView.beta_features) activates the banner for bug
listings.

test: /bin/test -vvt test_beta_notification

Demo/QA:

  - enable the feature flag bugs.dynamic_bug_listings.enabled
  - visit any bug listing, for example https://bugs.launchpad.dev/firefox

lint:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/app/javascript/beta-notification.js
  lib/lp/app/javascript/tests/test_beta_notification.html
  lib/lp/app/javascript/tests/test_beta_notification.js
  lib/lp/app/templates/base-layout-macros.pt
  lib/lp/bugs/browser/bugtask.py

./lib/canonical/launchpad/icing/style-3-0.css
      58: Unknown Property name.: -moz-border-radius
      59: Unknown Property name.: -webkit-border-radius
      60: Unknown Property name.: -khtml-border-radius
      61: Unknown Property name.: border-radius
[ca 700 lines deleted]
    2331: I003: To few newlines before selectors.
    2334: I003: To few newlines before selectors.
    2349: I003: To few newlines before selectors.
    2352: I003: To few newlines before selectors.


For more details, see:
https://code.launchpad.net/~adeuring/launchpad/banner-for-beta-features-2/+merge/81833
-- 
https://code.launchpad.net/~adeuring/launchpad/banner-for-beta-features-2/+merge/81833
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~adeuring/launchpad/banner-for-beta-features-2 into lp:launchpad.