launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

The proposal to merge lp:~mbp/launchpad/ec2-update into lp:launchpad has been updated.

Description changed to:

This makes ec2 test instances do an apt-get update, upgrade, before they start running the actual tests.

I've tested it here and it works and does not add much to the startup time.

In particular this lets me test out <https://code.launchpad.net/~mbp/launchpad/800295-delete-buildd/+merge/81815> without manually building a separate ami, and getting permission to make that api official.  Generally speaking it seems wasteful to have people repeatedly manually do something the computer can happily do.

Upsides:
 * less risk ami updates would go wrong
 * saves what stevenk estimates is an hour of latency updating the ami
 * less gap between what is tested, and what's used by developers and in deployment
 * avoids the issue of only particular people being trusted to update amis

Downsides:
 * a glitch might cause the update to fail - though that seems unlikely compared to all the risks of tests spuriously failing, and it can be detected pretty early
 * it will take a bit longer (~60s?) before the machine detaches - I think that is probably better handled by making the whole thing detach much earlier and run all the setup separately.  it is not very long as a fraction of the total startup time
 * possibly we'll get some failures due to incompatibilities with the particular versions of things in one of our ppas or in ubuntu - but it seems to me those problems were lurking already and this just helps us find them, which is probably good

This also removes henninge as a trusted AMI author (since it seems like the kind of thing only staff would be allowed to have) and adds me.

For more details, see:
https://code.launchpad.net/~mbp/launchpad/ec2-update/+merge/81946
-- 
https://code.launchpad.net/~mbp/launchpad/ec2-update/+merge/81946
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/ec2-update into lp:launchpad.