launchpad-reviewers team mailing list archive

[Richard Harding <rharding@xxxxxxxxxxxx>]

Richard Harding has proposed merging lp:~rharding/launchpad/bugfix_814696 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #814696 in Launchpad itself: "Link to show inline diffs in merge proposals should be green"
  https://bugs.launchpad.net/launchpad/+bug/814696

For more details, see:
https://code.launchpad.net/~rharding/launchpad/bugfix_814696/+merge/82214

The ajax_revision_diffs feature is an ajax request invoking link and was missing the js-action css class. Added to the template file.

-- 
https://code.launchpad.net/~rharding/launchpad/bugfix_814696/+merge/82214
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/bugfix_814696 into lp:launchpad.

=== modified file 'lib/lp/code/templates/branch-macros.pt'
--- lib/lp/code/templates/branch-macros.pt	2011-07-20 03:34:43 +0000
+++ lib/lp/code/templates/branch-macros.pt	2011-11-14 20:11:25 +0000
@@ -206,7 +206,7 @@
         condition="request/features/code.ajax_revision_diffs.enabled">
       <tal:diff-expander condition="show_diff_expander | nothing">
 	<div class="revision-group-diff" tal:condition="revisions | nothing">
-	  <a href="#" class="unseen expander-icon"
+	  <a href="#" class="unseen expander-icon js-action"
 	     tal:define="start_revno python:revisions[0].sequence;
 			 last_revno python:revisions[-1].sequence"
 	     tal:attributes="id string:expandable-${start_revno}-${last_revno}"