launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

> Can't you just use testtools.TestCase.getUniqueInteger? That should be
> unique across the process lifetime.

No, that's only unique per test.  

That ought to be enough if the tests are well isolated, but I wouldn't be surprised if there are some that actually do rely on the names being unique across tests.

Also that requires a TestCase object, and we don't easily have one in the ObjectFactory.

The implementation is basically the same (a counter) and the code is so small having it here doesn't seem so bad.
-- 
https://code.launchpad.net/~mbp/launchpad/891028-notunique/+merge/82480
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/891028-notunique into lp:launchpad.