launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

Deryck Hodge has proposed merging lp:~deryck/launchpad/listing-overlay-formatting-890695 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #890695 in Launchpad itself: "Form overlay used in CustomBugListings is format wrong for Firefox"
  https://bugs.launchpad.net/launchpad/+bug/890695

For more details, see:
https://code.launchpad.net/~deryck/launchpad/listing-overlay-formatting-890695/+merge/82581

This contains minor CSS tweaks to get the formoverlay used for bug listing config to format better as the browser window is scaled down to smaller sizes.  I was using (read: abusing) position: relative rules, and this obviously is bad when the overlay resizes.  I removed this in favor of setting the width on the form, which works much better.  I also set text-align left on the update input.  It seems we have roughly the same look now as the window is scaled up or down.
-- 
https://code.launchpad.net/~deryck/launchpad/listing-overlay-formatting-890695/+merge/82581
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/listing-overlay-formatting-890695 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2011-11-14 17:57:46 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2011-11-17 18:05:28 +0000
@@ -1032,13 +1032,11 @@
 .yui3-buglisting-config-util-overlay a.close-button {
     visibility: inherit;
     }
-.yui3-buglisting-config-util-overlay .buglisting-opts {
-    position: relative;
-    left: -110px;
+.yui3-buglisting-config-util-overlay form {
+    width: 80%;
     }
-.yui3-buglisting-config-util-overlay .update-buglisting {
-    position: relative;
-    left: -240px;
+.yui3-buglisting-config-util-overlay div.yui3-lazr-formoverlay-actions {
+    text-align: left;
     }
 .yui3-buglisting-config-util-overlay .reset-buglisting {
     position: relative;