launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #05609
[Merge] lp:~mbp/launchpad/888353-microformats into lp:launchpad
Martin Pool has proposed merging lp:~mbp/launchpad/888353-microformats into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #888353 in Launchpad itself: "google could give better snippets if launchpad used schema.org microformats"
https://bugs.launchpad.net/launchpad/+bug/888353
For more details, see:
https://code.launchpad.net/~mbp/launchpad/888353-microformats/+merge/82767
This adds a small amount of schemas.org to the main bug page and to the generic breadcrumbs, with a goal of getting search engines to give better summaries snippets of bug pages that turn up in search results.
To see whether it actually does work or not we'll need to deploy this and wait for it to be indexed. We could do a lot more but this is an experiment to see if it has a noticeable effect.
There are not any (intentional) changes is normal page content or behaviour.
You can see Google's test parser on it at <http://www.google.com/webmasters/tools/richsnippets?url=http%3A%2F%2Fsourcefrog.net%2Ftmp%2F1w%2Fbug1.html&view=cse>.
--
https://code.launchpad.net/~mbp/launchpad/888353-microformats/+merge/82767
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/888353-microformats into lp:launchpad.
=== modified file 'lib/lp/app/templates/base-layout.pt'
--- lib/lp/app/templates/base-layout.pt 2011-09-06 15:31:28 +0000
+++ lib/lp/app/templates/base-layout.pt 2011-11-19 06:04:29 +0000
@@ -58,6 +58,7 @@
</head>
<body id="document"
+ itemscope itemtype="http://schema.org/WebPage";
tal:attributes="class string:tab-${view/menu:selectedfacetname}
${view/macro:pagetype}
${view/context/fmt:public-private-css}
=== modified file 'lib/lp/app/templates/launchpad-hierarchy.pt'
--- lib/lp/app/templates/launchpad-hierarchy.pt 2010-07-21 18:03:44 +0000
+++ lib/lp/app/templates/launchpad-hierarchy.pt 2011-11-19 06:04:29 +0000
@@ -1,4 +1,5 @@
<ol
+ itemprop="breadcrumb"
class="breadcrumbs"
xmlns:tal="http://xml.zope.org/namespaces/tal";
xmlns:metal="http://xml.zope.org/namespaces/metal";
=== modified file 'lib/lp/bugs/templates/bugcomment-box.pt'
--- lib/lp/bugs/templates/bugcomment-box.pt 2011-09-01 10:54:38 +0000
+++ lib/lp/bugs/templates/bugcomment-box.pt 2011-11-19 06:04:29 +0000
@@ -2,6 +2,7 @@
xmlns="http://www.w3.org/1999/xhtml";
xmlns:tal="http://xml.zope.org/namespaces/tal";
xmlns:metal="http://xml.zope.org/namespaces/metal";
+ itemscope itemtype="http://schema.org/UserComments";
tal:define="comment context;
remote_bug_comment_class
python: comment.bugwatch and 'remoteBugComment' or '';
@@ -20,6 +21,7 @@
replace="structure comment/owner/fmt:link-display-name-id" />
wrote
<span tal:attributes="title comment/datecreated/fmt:datetime"
+ itemprop="commentTime"
tal:content="comment/datecreated/fmt:displaydate">
7 minutes ago
</span>:
@@ -46,8 +48,9 @@
</a>
</td>
<td class="bug-comment-index">
- <a tal:attributes="href comment/fmt:url"
- tal:content="string: #${comment/index}" />
+ <a itemprop="url"
+ tal:attributes="href comment/fmt:url"
+ tal:content="string: #${comment/index}" />
</td>
</tr>
</tbody>
@@ -79,7 +82,7 @@
</li>
</ul>
- <div class="bug-comment"
+ <div class="bug-comment" itemprop="commentText"
tal:content="structure
comment/text_for_display/fmt:obfuscate-email/fmt:email-to-html">
Comment text.
=== modified file 'lib/lp/bugs/templates/bugtask-index.pt'
--- lib/lp/bugs/templates/bugtask-index.pt 2011-11-10 10:51:37 +0000
+++ lib/lp/bugs/templates/bugtask-index.pt 2011-11-19 06:04:29 +0000
@@ -129,7 +129,7 @@
<div><!-- id="nonportlets"> -->
<div class="top-portlet">
- <div class="report">
+ <div itemprop="mainContentOfPage" class="report">
<tal:description
define="global description context/bug/description/fmt:obfuscate-email/fmt:text-to-html" />
