launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

Robert Collins has proposed merging lp:~lifeless/python-oops-tools/bug-892917 into lp:python-oops-tools.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lifeless/python-oops-tools/bug-892917/+merge/82841

Permit wider fields in the DB.
-- 
https://code.launchpad.net/~lifeless/python-oops-tools/bug-892917/+merge/82841
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~lifeless/python-oops-tools/bug-892917 into lp:python-oops-tools.

=== modified file 'src/oopstools/NEWS.txt'
--- src/oopstools/NEWS.txt	2011-11-16 23:21:38 +0000
+++ src/oopstools/NEWS.txt	2011-11-21 03:55:25 +0000
@@ -33,6 +33,9 @@
 * The OOPS reporter field - or prefix as it was known - is now shown
   in the OOPS details page. (Robert Collins)
 
+* The prefix and appinstance values can now be up to 100 characters long.
+  (Robert Collins, #892917)
+
 * The req_vars variable in OOPS reports may now be a dict.
   (Robert Collins, #888866)
 

=== added file 'src/oopstools/oops/migrations/0021_longer_reporter.py'
--- src/oopstools/oops/migrations/0021_longer_reporter.py	1970-01-01 00:00:00 +0000
+++ src/oopstools/oops/migrations/0021_longer_reporter.py	2011-11-21 03:55:25 +0000
@@ -0,0 +1,29 @@
+# Copyright 2011 Canonical Ltd.  All rights reserved.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+from django.db import models
+from south.v2 import DataMigration
+from south.db import db
+
+
+class Migration(DataMigration):
+
+    def forwards(self, orm):
+        db.alter_column('oops_prefix', 'value', models.CharField(unique=True, max_length=100))
+        db.alter_column('oops_appinstance', 'title', models.CharField(unique=True, max_length=100))
+
+    def backwards(self, orm):
+        db.alter_column('oops_prefix', 'value', models.CharField(unique=True, max_length=20))
+        db.alter_column('oops_appinstance', 'title', models.CharField(unique=True, max_length=50))