← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~rvb/launchpad/activereviews-bug-867941-eagerload2 into lp:launchpad

 

> That remaining query just needs a bit more cachedproperty love - see for
> instance BranchCollection which does the same trick with backreferences
> elsewhere in the branch space.

Thanks for helping me out with this.  I did not realize the lookup was caused by a security check.
Since the number of storm references in queries plus the number of places where the field is set is greater than the number of places where the field is read, I've decided to keep branch_merge_proposal as the Reference and add a cached property named _branch_merge_proposal.
-- 
https://code.launchpad.net/~rvb/launchpad/activereviews-bug-867941-eagerload2/+merge/82904
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/launchpad/activereviews-bug-867941-eagerload2 into lp:launchpad.


References