launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #05665
[Merge] lp:~jcsackett/launchpad/update-loggerhead-for-privacy-icon into lp:launchpad
j.c.sackett has proposed merging lp:~jcsackett/launchpad/update-loggerhead-for-privacy-icon into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #893982 in Launchpad itself: "loggerhead privacy ribbon doesn't have pad lock icon"
https://bugs.launchpad.net/launchpad/+bug/893982
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/update-loggerhead-for-privacy-icon/+merge/83222
This is a simple change to bump the loggerhead revision so that the privacy icon is show as part of the privacy ribbon on loggerhead, as it is on private pages in lp.
QA
==
Open a private branch on loggerhead; the privacy ribbon should appear and have the padlock icon as it does on LP.
For more information see: https://code.launchpad.net/~jcsackett/loggerhead/add-lock-icon/+merge/83203
--
https://code.launchpad.net/~jcsackett/launchpad/update-loggerhead-for-privacy-icon/+merge/83222
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/update-loggerhead-for-privacy-icon into lp:launchpad.
=== modified file 'utilities/sourcedeps.conf'
--- utilities/sourcedeps.conf 2011-11-14 14:11:14 +0000
+++ utilities/sourcedeps.conf 2011-11-23 20:37:32 +0000
@@ -6,7 +6,7 @@
cscvs lp:~launchpad-pqm/launchpad-cscvs/devel;revno=432
dulwich lp:~launchpad-pqm/dulwich/devel;revno=433
difftacular lp:difftacular;revno=6
-loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=459
+loggerhead lp:~loggerhead-team/loggerhead/trunk-rich;revno=500
lpreview lp:~launchpad-pqm/bzr-lpreview/devel;revno=23
mailman lp:~launchpad-pqm/mailman/2.1;revno=976
mustache.js lp:mustache.js;revno=166
Follow ups