launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/history-model-fix into lp:launchpad with lp:~abentley/launchpad/history-model as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~abentley/launchpad/history-model-fix/+merge/83995

= Summary =
Prevent Chrom(e|ium) from messing with our state.

== Proposed fix ==
Take advantage of the existing popstate detection to reinstate our values.

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
None

== Demo and Q/A ==
Use Chromium or Chrome to visit a bug listing page such as https://bugs.qastaging.launchpad.net/nova/+bugs

The navigation links and order-by widget should work.


= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/bugs/javascript/buglisting.js
  lib/lp/bugs/templates/buglisting-default.pt
  lib/lp/bugs/javascript/tests/test_buglisting_utils.html
  lib/lp/bugs/javascript/tests/test_buglisting_utils.js
  lib/lp/bugs/javascript/tests/test_buglisting.js
  lib/lp/bugs/javascript/buglisting_utils.js
-- 
https://code.launchpad.net/~abentley/launchpad/history-model-fix/+merge/83995
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/history-model-fix into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/buglisting.js'
--- lib/lp/bugs/javascript/buglisting.js	2011-11-30 19:03:30 +0000
+++ lib/lp/bugs/javascript/buglisting.js	2011-11-30 19:03:31 +0000
@@ -171,6 +171,10 @@
             this.pre_fetch_batches();
             this.render();
         }
+        else {
+            // Handle Chrom(e|ium)'s initial popstate.
+            this.get('model').get('history').replace(e.prevVal);
+        }
     },
 
     /**