launchpad-reviewers team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

AFAIK this is hooked in wrongly - you should instead grant launchpad.Admin on the object on demo sites - the view shouldn't be conditionally checking. (Or the needed access could be launchpad.Edit always, and again, you sometimes offer that to e.g. ~registry).

That said, the question is how we should implement 'permit a different team to edit rules'.

I don't think 'demo site' is a particularly good knob to use here, as its unobvious. I'd much rather one of the options I put forward in https://bugs.launchpad.net/launchpad/+bug/790025/comments/1.
-- 
https://code.launchpad.net/~mbp/launchpad/feature-admin-party/+merge/84044
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/feature-admin-party into lp:launchpad.