launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

Martin Pool has proposed merging lp:~mbp/launchpad/666765-features-no-reasons into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #666765 in Launchpad itself: "page source shows all feature scopes examined [disclosure leak]"
  https://bugs.launchpad.net/launchpad/+bug/666765

For more details, see:
https://code.launchpad.net/~mbp/launchpad/666765-features-no-reasons/+merge/84050

Per <https://bugs.launchpad.net/launchpad/+bug/666765> users may be subjected to or excluded from particular features without being allowed to know why. 

We could possibly track the features and scopes in the timeline (if it's not already) to make it easy for developers to get at it.
-- 
https://code.launchpad.net/~mbp/launchpad/666765-features-no-reasons/+merge/84050
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/666765-features-no-reasons into lp:launchpad.

=== modified file 'lib/lp/app/templates/base-layout.pt'
--- lib/lp/app/templates/base-layout.pt	2011-11-25 02:19:28 +0000
+++ lib/lp/app/templates/base-layout.pt	2011-12-01 02:32:33 +0000
@@ -187,7 +187,6 @@
     At least ${log}
 
     Features: ${request/features/usedFlags}
-    in scopes ${request/features/usedScopes}
 
     r${revno}
   --&gt;" />