launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/single-line-bugs-894442 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #894442 in Launchpad itself: "Dynamic bug listings are too sparse"
  https://bugs.launchpad.net/launchpad/+bug/894442

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/single-line-bugs-894442/+merge/84194

In response to feedback we've decided to move the default info onto one line and if you add more fields they'll display on the second line.

Also in this branch I've made the following changes:
Removed some extra space at the bottom of each row.
Restyled search box.
Fixed milestone badge icons from dropping down to the second line.
Moved CSS into own component (was in style.css, now in bug_listing.css in components dir).
Improved column widths by using percents (this particularly helps with users who have wide monitors): https://bugs.launchpad.net/launchpad/+bug/897097.


A screenshot of some of the changes: https://launchpadlibrarian.net/86370773/single_line_bugs.png
-- 
https://code.launchpad.net/~huwshimi/launchpad/single-line-bugs-894442/+merge/84194
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/single-line-bugs-894442 into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/colours.css'
--- lib/canonical/launchpad/icing/css/colours.css	2011-11-22 16:38:00 +0000
+++ lib/canonical/launchpad/icing/css/colours.css	2011-12-02 01:01:41 +0000
@@ -127,39 +127,54 @@
 .importanceUNDECIDED, .importanceUNDECIDED a {
     color: #999;
     }
+#client-listing .statusUNKNOWN, #client-listing .statusUNKNOWN a,
 #client-listing .statusNEW, #client-listing .statusNEW a,
-#client-listing .statusINCOMPLETE, #client-listing .statusINCOMPLETE a,
+#client-listing .statusINCOMPLETE, #client-listing .statusINCOMPLETE a {
+        color: #464646;
+        background-color: #ddd;
+    }
 #client-listing .statusCONFIRMED, #client-listing .statusCONFIRMED a,
-#client-listing .statusTRIAGED, #client-listing .statusTRIAGED a,
-#client-listing .statusFIXCOMMITTED, #client-listing .statusFIXCOMMITTED a,
-#client-listing .statusFIXRELEASED, #client-listing .statusFIXRELEASED a,
+#client-listing .statusTRIAGED, #client-listing .statusTRIAGED a {
+        color: #896e00;
+        background-color: #f4f1a4;
+    }
+#client-listing .statusINPROGRESS, #client-listing .statusINPROGRESS a,
+#client-listing .statusFIXCOMMITTED, #client-listing .statusFIXCOMMITTED a {
+        color: #137587;
+        background-color: #cbe7ef;
+    }
+#client-listing .statusFIXRELEASED, #client-listing .statusFIXRELEASED a {
+        color: #4f7b10;
+        background-color: #cef1a0;
+    }
 #client-listing .statusINVALID, #client-listing .statusINVALID a,
 #client-listing .statusWONTFIX, #client-listing .statusWONTFIX a,
-#client-listing .statusUNKNOWN, #client-listing .statusUNKNOWN a {
-    color: #666;
+#client-listing .statusOPINION, #client-listing .statusOPINION a {
+        color: #8b5600;
+        background-color: #ffd4c9;
     }
 #client-listing .importanceCRITICAL, #client-listing .importanceCRITICAL a {
-    background: #DF382C;
+    background-color: #DF382C;
     color: white;
     }
 #client-listing .importanceHIGH, #client-listing .importanceHIGH a {
-    background: #EFB73E;
+    background-color: #EFB73E;
     color: white;
     }
 #client-listing .importanceMEDIUM, #client-listing .importanceMEDIUM a {
-    background: #19B6EE;
+    background-color: #19B6EE;
     color: white;
     }
 #client-listing .importanceLOW, #client-listing .importanceLOW a {
-    background: #38B44A;
+    background-color: #38B44A;
     color: white;
     }
 #client-listing .importanceWISHLIST, #client-listing .importanceWISHLIST a {
-    background: #724dc8;
+    background-color: #724dc8;
     color: white;
     }
 #client-listing .importanceUNDECIDED, #client-listing .importanceUNDECIDED a {
-    background: #666666;
+    background-color: #666666;
     color: white;
     }
 

=== added file 'lib/canonical/launchpad/icing/css/components/bug_listing.css'
--- lib/canonical/launchpad/icing/css/components/bug_listing.css	1970-01-01 00:00:00 +0000
+++ lib/canonical/launchpad/icing/css/components/bug_listing.css	2011-12-02 01:01:41 +0000
@@ -0,0 +1,56 @@
+div#client-listing {
+    float: left;
+    color: #666;
+    }
+div.buglisting-row {
+    float: left;
+    margin-top: 5px;
+    padding-bottom: 5px;
+    border-bottom: 1px solid #EEE;
+    min-width: 585px;
+    width: 100%;
+    }
+div.buglisting-col1 {
+    float: left;
+    padding-right: 20px;
+    }
+div.buglisting-col2 {
+    width: 60%;
+    float: left;
+    margin-top: 2px;
+    }
+div.buglisting-col3 {
+    float: right;
+    }
+div#client-listing .status,
+div#client-listing .importance {
+    float: left;
+    height: 1.5em;
+    font-size: 0.8em;
+    border-radius: 2px;
+    text-transform: uppercase;
+    line-height: 12px;
+    text-align: center;
+    margin: 5px 0 2px 10px;
+}
+div#client-listing .importance {
+    width: 65px;
+    }
+div#client-listing .status {
+    width: 90px;
+    }
+div#client-listing .buginfo-extras {
+    margin-top: 3px;
+    }
+div#client-listing .bug-related-icons,
+div#client-listing .bug-heat-icons {
+    float: right;
+    margin: 3px 0;
+    }
+div#client-listing .field {
+    display: inline-block;
+    min-width: 20%;
+    line-height: 16px;
+    margin-right: 5px;
+}
+

=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css	2011-11-23 03:58:39 +0000
+++ lib/canonical/launchpad/icing/style.css	2011-12-02 01:01:41 +0000
@@ -69,10 +69,11 @@
 }
 
 div#bugs-search-form.dynamic_bug_listing {
-    background: #EEE;
-    padding: 2px 15px;
-    border-radius: 10px;
-    margin-bottom: 5px;
+    margin-bottom: 10px;
+    padding: 3px 0;
+    border-width: 1px 0;
+    border-style: solid;
+    border-color: #EBEBEB;
 }
 
 form.primary.search.dynamic_bug_listing {
@@ -675,67 +676,6 @@
   display: inline;
 }
 
-/* Rules for CustomBugListings bug search result lists. */
-div#client-listing {
-    float: left;
-    color: #666;
-    }
-div.buglisting-row {
-    float: left;
-    margin-top: 5px;
-    border-bottom: 1px solid #EEE;
-    min-width: 585px;
-    width: 100%;
-    padding-bottom: 5px;
-    }
-div.buglisting-col1 {
-    width: 100px;
-    float: left;
-    padding-bottom: 8px;
-    }
-div.buglisting-col2 {
-    width: 70%;
-    float: left;
-    }
-div.buglisting-col3 {
-    width: 10%;
-    float: right;
-    }
-div#client-listing .importance {
-    height: 1.5em;
-    width: 65px;
-    font-size: .8em;
-    border-radius: 2px;
-    text-transform: uppercase;
-    line-height: 12px;
-    margin: 5px 50px 2px 0;
-    text-align: center;
-    position: relative;
-    left: 10px;
-    }
-div#client-listing .buglisting-col2 {
-    position: relative;
-    top: 2px;
-    }
-div#client-listing .bug-related-icons {
-    float: right;
-    margin: 3px 0 3px 0;
-    }
-div#client-listing .bug-heat-icons {
-    float: right;
-    margin: 3px 0 3px 0;
-    }
-div#client-listing .status {
-    position: relative;
-    left: 10px;
-    }
-div#client-listing .field {
-    display: inline-block;
-    min-width: 120px;
-    line-height: 16px;
-    margin-right: 5px;
-}
-
 /* Tags portlet */
 .tag-list {
     margin-bottom: 0.5em;

=== modified file 'lib/lp/app/browser/tales.py'
--- lib/lp/app/browser/tales.py	2011-11-16 00:09:49 +0000
+++ lib/lp/app/browser/tales.py	2011-12-02 01:01:41 +0000
@@ -912,7 +912,7 @@
         '<span alt="%s" title="%s" class="%s">&nbsp;</span>')
 
     linked_icon_template = (
-        '<a href="%s" alt="%s" title="%s" class="%s"></a>')
+        '<a href="%s" alt="%s" title="%s" class="%s">&nbsp;</a>')
 
     def traverse(self, name, furtherPath):
         """Special-case traversal for icons with an optional rootsite."""