launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/prettier-private-build into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/prettier-private-build/+merge/84415

r14430 made private recipe builds show up on Builder:+history as "private Build". This branch changes it to "Private job", which has more sensible capitalisation and matches the "Building private job" used on BuilderSet:+index.
-- 
https://code.launchpad.net/~wgrant/launchpad/prettier-private-build/+merge/84415
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/prettier-private-build into lp:launchpad.

=== modified file 'lib/lp/soyuz/browser/tests/test_builder_views.py'
--- lib/lp/soyuz/browser/tests/test_builder_views.py	2011-12-02 14:49:11 +0000
+++ lib/lp/soyuz/browser/tests/test_builder_views.py	2011-12-05 00:55:28 +0000
@@ -303,7 +303,7 @@
             soupmatchers.Tag(
                 'Private build icon', 'img', attrs={'src': '/@@/private'}))
         private_build_matcher = soupmatchers.HTMLContains(
-            soupmatchers.Tag('Private build', 'td', text='private Build'))
+            soupmatchers.Tag('Private build', 'td', text='Private job'))
 
         self.assertThat(
             view.render(),

=== modified file 'lib/lp/soyuz/templates/builds-list.pt'
--- lib/lp/soyuz/templates/builds-list.pt	2011-12-02 14:33:58 +0000
+++ lib/lp/soyuz/templates/builds-list.pt	2011-12-05 00:55:28 +0000
@@ -113,10 +113,10 @@
         </tr>
         <tr class="build-row" tal:condition="not: build">
           <td class="left icon">
-            <img width="14" height="14" alt="[PRIVATE BUILD]"
+            <img width="14" height="14" alt="[PRIVATE JOB]"
                  title="Private" src="/@@/private" />
           </td>
-          <td tal:condition="not: build">private Build</td>
+          <td tal:condition="not: build">Private job</td>
         </tr>
       </tal:batch_repeat>
     </tbody>