launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: "Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>
Date: Wed, 07 Dec 2011 05:15:26 -0000
In-reply-to: <20111206150549.23901.78467.launchpad@ackee.canonical.com>
Reply-to: mp+84624@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

A note on the problem of ensuring that a PublisherConfig is in place: factory.makeDistribution creates one for you.  Just make sure to pass it a publish_root_dir, or I think it will use default system config.  This should probably be considered a bug in the factory.
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-cron-germinate/+merge/84624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad.

References

[Merge] lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad
From: Colin Watson, 2011-12-06