launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Some very nice tests there!  To continue:

=== added file 'lib/lp/archivepublisher/tests/test_generate_extra_overrides.py'


+def file_contents(path):
+    """Return the contents of the file at path."""
+    with open(path) as handle:
+        return handle.read()

Since you're only reading the file, there's probably no hurry to close this file handle.  So you could just return “open(path).read().”
-- 
https://code.launchpad.net/~cjwatson/launchpad/refactor-cron-germinate/+merge/84624
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/refactor-cron-germinate into lp:launchpad.