← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~rharding/launchpad/link_tags_894726 into lp:launchpad

 

= Summary = 
We want clickable links for the tags on each bug listed in the display

== Implementation Details ==
Currently the design will not keep current search, sort, or filter criteria when clicking the links. It's not an aid in narrowing down results based on the current view.

In order to build the links, it needs to be done on the server side. We don't currently have good helpers for generating urls on the client side. This required adding an attribute (tag_urls) to the flattened BugTaskListingItem.model property. In order to have better display control. For consistancy, the tags attribute was also changed to be a list of dictionaries. This allows the mustache templates to have better control over the rendering of the tags.

== Demo && Q/A == 
To check this head to a bug listing with the new buglisting feature enabled, bugs.xxxx/launchpad/ for instance, and find a bug with tags on it. Each tag should appear as a link and clicking that link should take you to a new list of bugs that are limited to just the tag selected.

== Tests ==
bin/test -cvt "browser.*test_bugtask"

-- 
https://code.launchpad.net/~rharding/launchpad/link_tags_894726/+merge/85673
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/link_tags_894726 into lp:launchpad.