launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #05941
[Merge] lp:~huwshimi/launchpad/inline-fields into lp:launchpad
Huw Wilkins has proposed merging lp:~huwshimi/launchpad/inline-fields into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
Related bugs:
Bug #894442 in Launchpad itself: "Dynamic bug listings are too sparse"
https://bugs.launchpad.net/launchpad/+bug/894442
For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/inline-fields/+merge/85798
This branch modifies the bug listing so that additional fields are displayed on the first line unless there are too many extra fields to fit, in which case the whole row of additional information is pushed onto the second line.
I had to shuffle some divs in the template a little, hence the big block moved around in buglisting.mustache.
A screenshot of the listing in both cases is here:
https://launchpadlibrarian.net/87516628/single_line_bugs_improved.png
--
https://code.launchpad.net/~huwshimi/launchpad/inline-fields/+merge/85798
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/inline-fields into lp:launchpad.
=== modified file 'lib/canonical/launchpad/icing/css/components/bug_listing.css'
--- lib/canonical/launchpad/icing/css/components/bug_listing.css 2011-11-30 07:05:00 +0000
+++ lib/canonical/launchpad/icing/css/components/bug_listing.css 2011-12-15 06:42:26 +0000
@@ -5,22 +5,22 @@
div.buglisting-row {
float: left;
margin-top: 5px;
- padding-bottom: 5px;
+ padding: 0 0 5px 10px;
border-bottom: 1px solid #EEE;
min-width: 585px;
width: 100%;
}
div.buglisting-col1 {
float: left;
- padding-right: 20px;
+ padding-right: 10px;
+ }
+div.buglisting-col2,
+div.buglisting-col3 {
+ float: left;
+ margin-top: 2px;
}
div.buglisting-col2 {
- width: 60%;
- float: left;
- margin-top: 2px;
- }
-div.buglisting-col3 {
- float: right;
+ width: 40%;
}
div#client-listing .status,
div#client-listing .importance {
@@ -31,7 +31,7 @@
text-transform: uppercase;
line-height: 12px;
text-align: center;
- margin: 5px 0 2px 10px;
+ margin: 5px 10px 0 0;
}
div#client-listing .importance {
width: 65px;
@@ -39,18 +39,9 @@
div#client-listing .status {
width: 90px;
}
-div#client-listing .buginfo-extras {
- margin-top: 3px;
- }
-div#client-listing .bug-related-icons,
-div#client-listing .bug-heat-icons {
- float: right;
- margin: 3px 0;
- }
div#client-listing .field {
display: inline-block;
- min-width: 20%;
+ min-width: 13em;
line-height: 16px;
margin-right: 5px;
-}
-
+ }
=== modified file 'lib/lp/bugs/templates/buglisting.mustache'
--- lib/lp/bugs/templates/buglisting.mustache 2011-12-08 13:23:00 +0000
+++ lib/lp/bugs/templates/buglisting.mustache 2011-12-15 06:42:26 +0000
@@ -22,53 +22,50 @@
{{/show_id}}
<a href="{{bug_url}}" class="bugtitle">{{title}}</a>
</div>
- <div class="buginfo-extras">
- {{#show_targetname}}
- <span class="{{bugtarget_css}} field">
- {{bugtarget}}
- </span>
- {{/show_targetname}}
- {{#show_milestone_name}}
- <span class="sprite milestone field">
- {{#milestone_name}}
- {{milestone_name}}
- {{/milestone_name}}
- {{^milestone_name}}
- No milestone set
- {{/milestone_name}}
- </span>
- {{/show_milestone_name}}
- {{#show_date_last_updated}}
- <span class="sprite milestone field">
- Last updated {{last_updated}}
- </span>
- {{/show_date_last_updated}}
- {{#show_assignee}}
- <span class="sprite person field">
- {{#assignee}}Assignee: {{assignee}}{{/assignee}}
- {{^assignee}}Assignee: None{{/assignee}}
- </span>
- {{/show_assignee}}
- {{#show_reporter}}
- <span class="sprite person field">
- Reporter: {{reporter}}
- </span>
- {{/show_reporter}}
- {{#show_datecreated}}
- <span class="sprite milestone field">
- {{age}}
- </span>
- {{/show_datecreated}}
- {{#show_tag}}
- <span class="field">Tags:
- {{#tags}}{{tags}}{{/tags}}
- {{^tags}}None{{/tags}}
- </span>
- {{/show_tag}}
- </div>
</div>
-
<div class="buglisting-col3">
+ {{#show_targetname}}
+ <span class="{{bugtarget_css}} field">
+ {{bugtarget}}
+ </span>
+ {{/show_targetname}}
+ {{#show_milestone_name}}
+ <span class="sprite milestone field">
+ {{#milestone_name}}
+ {{milestone_name}}
+ {{/milestone_name}}
+ {{^milestone_name}}
+ No milestone set
+ {{/milestone_name}}
+ </span>
+ {{/show_milestone_name}}
+ {{#show_date_last_updated}}
+ <span class="sprite milestone field">
+ Last updated {{last_updated}}
+ </span>
+ {{/show_date_last_updated}}
+ {{#show_assignee}}
+ <span class="sprite person field">
+ {{#assignee}}Assignee: {{assignee}}{{/assignee}}
+ {{^assignee}}Assignee: None{{/assignee}}
+ </span>
+ {{/show_assignee}}
+ {{#show_reporter}}
+ <span class="sprite person field">
+ Reporter: {{reporter}}
+ </span>
+ {{/show_reporter}}
+ {{#show_datecreated}}
+ <span class="sprite milestone field">
+ {{age}}
+ </span>
+ {{/show_datecreated}}
+ {{#show_tag}}
+ <span class="field">Tags:
+ {{#tags}}{{tags}}{{/tags}}
+ {{^tags}}None{{/tags}}
+ </span>
+ {{/show_tag}}
{{#show_heat}}
<span class="bug-heat-icons">
{{{bug_heat_html}}}
