launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Richard Harding has proposed merging lp:~rharding/launchpad/pagination_905228 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #905228 in Launchpad itself: "Cannot use pagination links on bug listings"
  https://bugs.launchpad.net/launchpad/+bug/905228

For more details, see:
https://code.launchpad.net/~rharding/launchpad/pagination_905228/+merge/86033

= Summary = 
In chrome, the bug listing pagination would fail due to missing batch information in the model. 

== Implementation ==
There was a duplicate call to the superclass's initializer. YUI will chain those for us and calling again just caused another pass through there that caused init issues when chained with Chrome's popping of the history on page load by default.

== Tests ==
lib/lp/bugs/javascript/tests/test_buglisting.html
lib/lp/app/javascript/tests/test_listing_navigator.html
-- 
https://code.launchpad.net/~rharding/launchpad/pagination_905228/+merge/86033
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/pagination_905228 into lp:launchpad.

=== modified file 'lib/lp/bugs/javascript/buglisting.js'
--- lib/lp/bugs/javascript/buglisting.js	2011-12-14 19:23:02 +0000
+++ lib/lp/bugs/javascript/buglisting.js	2011-12-16 12:36:26 +0000
@@ -122,7 +122,6 @@
     module.BugListingNavigator,
     Y.lp.app.listing_navigator.ListingNavigator, {
     initializer: function(config) {
-        this.constructor.superclass.initializer.apply(this, arguments);
         this.get('model').get('history').after(
             'change', this.history_changed, this);
     },