launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/force-checkwatches-production into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #906151 in Launchpad itself: "checkwatches depends on checkwatches config section"
  https://bugs.launchpad.net/launchpad/+bug/906151

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/force-checkwatches-production/+merge/86187

Remove checkwatches special error reporting so that it uses production to write out oopsii.
-- 
https://code.launchpad.net/~stevenk/launchpad/force-checkwatches-production/+merge/86187
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/force-checkwatches-production into lp:launchpad.

=== modified file 'lib/lp/bugs/scripts/checkwatches/base.py'
--- lib/lp/bugs/scripts/checkwatches/base.py	2011-03-11 03:19:07 +0000
+++ lib/lp/bugs/scripts/checkwatches/base.py	2011-12-19 04:26:26 +0000
@@ -39,12 +39,6 @@
 MAX_SQL_STATEMENTS_LOGGED = 10000
 
 
-class CheckWatchesErrorUtility(ErrorReportingUtility):
-    """An error utility that for the checkwatches process."""
-
-    _default_config_section = 'checkwatches'
-
-
 def report_oops(message=None, properties=None, info=None,
                 transaction_manager=None):
     """Record an oops for the current exception.
@@ -91,7 +85,7 @@
 
     # Create the dummy request object.
     request = ScriptRequest(properties, url)
-    error_utility = CheckWatchesErrorUtility()
+    error_utility = ErrorReportingUtility()
     error_utility.raising(info, request)
     return request